From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbbDCPw4 (ORCPT ); Fri, 3 Apr 2015 11:52:56 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:39551 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbbDCPww (ORCPT ); Fri, 3 Apr 2015 11:52:52 -0400 Date: Fri, 3 Apr 2015 23:52:46 +0800 From: Herbert Xu To: Stephan Mueller Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] crypto: remove instance when test failed Message-ID: <20150403155246.GA21458@gondor.apana.org.au> References: <3394653.LODBE1uz62@tachyon.chronox.de> <20150403095828.GA19273@gondor.apana.org.au> <1731327.mgbsjj4MeV@tachyon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1731327.mgbsjj4MeV@tachyon.chronox.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 03, 2015 at 05:17:13PM +0200, Stephan Mueller wrote: > > Wpuldn't crypto_del_alg suffer from the same issue? I see that the cra_refcnt > is checked. But I guess there would be the same kind of race? You're quite right. It too needs to take a ref count on the algorithm in crypto_alg_match before releasing the mutex. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt