From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbDFP4G (ORCPT ); Mon, 6 Apr 2015 11:56:06 -0400 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:55619 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752965AbbDFPz7 (ORCPT ); Mon, 6 Apr 2015 11:55:59 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:3874:4605:5007:6261:7875:7904:9389:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: ants26_6e4306363515e X-Filterd-Recvd-Size: 2411 Date: Mon, 6 Apr 2015 11:55:56 -0400 From: Steven Rostedt To: Tom Zanussi Cc: Paul Bolle , masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command Message-ID: <20150406115556.7299cf8f@gandalf.local.home> In-Reply-To: <1428178145.2610.13.camel@picadillo> References: <9fe50519aa2cac1550b40a0e396dd721eff03574.1428072891.git.tom.zanussi@linux.intel.com> <1428160496.7898.132.camel@x220> <1428178145.2610.13.camel@picadillo> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 04 Apr 2015 15:09:05 -0500 Tom Zanussi wrote: > > [PATCH] kallsyms: Include module.h > > KSYM_SYMBOL_LEN references MODULE_NAME_LEN, defined in module.h, so > have kallsyms.h include module.h instead of expecting kallsysms users > to do it. > > Also fix up existing kallsyms users that apparently include module.h > for only that reason. > > Signed-off-by: Tom Zanussi > --- > include/linux/ftrace.h | 1 - > include/linux/kallsyms.h | 1 + > kernel/trace/trace_events_hist.c | 2 +- > kernel/trace/trace_kprobe.c | 1 + > kernel/trace/trace_output.c | 1 + > kernel/trace/trace_syscalls.c | 2 +- > 6 files changed, 5 insertions(+), 3 deletions(-) Not sure you are proposing this as part of your patch set. I suggest that you don't and post this separately. Also, the removal of kallsyms.h from ftrace.h should be a totally separate patch (along fixing anything that breaks when you remove it, if C files were using ftrace.h to pull in kallsyms.h for them). Then the addition of modules.h to kallsyms.h should be a separate patch. And you should compile the kernel with both a make allmodconfig, make allyesconfig, and then make allyesconfig but disable modules, and see if anything breaks. -- Steve