From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbbDFQZy (ORCPT ); Mon, 6 Apr 2015 12:25:54 -0400 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:46583 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752709AbbDFQZx (ORCPT ); Mon, 6 Apr 2015 12:25:53 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 13,1.2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2692:2893:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:5007:6261:7875:7903:8526:10008:10400:10848:10967:11232:11658:11914:12294:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:2:0 X-HE-Tag: teeth39_50534cdd6ce36 X-Filterd-Recvd-Size: 2055 Date: Mon, 6 Apr 2015 12:25:51 -0400 From: Steven Rostedt To: Paul Bolle Cc: Tom Zanussi , masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command Message-ID: <20150406122551.6e9ab8bc@gandalf.local.home> In-Reply-To: <1428337159.634.132.camel@x220> References: <9fe50519aa2cac1550b40a0e396dd721eff03574.1428072891.git.tom.zanussi@linux.intel.com> <1428160496.7898.132.camel@x220> <20150406115012.179e3fa6@gandalf.local.home> <1428337159.634.132.camel@x220> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Apr 2015 18:19:19 +0200 Paul Bolle wrote: > But the main reason I added that remark was that recently I ran into a > few patches where I made annoying mistakes in parsing changes to > Makefiles. Doing so I wasted my own and other peoples time. So I decided > to be rather verbose when Makefiles are involved. Just so that people > can: > - mock me for not getting basic stuff right; I hope you don't think I was mocking you. I wasn't. > - stop paying attention to the rest of my remarks, because chances are I > didn't understand the patch in question correctly. I wouldn't put your comments up as useless. I could imagine people going through and cleaning up header includes, as long as not much impact is made. The only issue I can think of that including an unneeded header file does is to make the compile slightly longer. It's not a major need to do, but it may be done. -- Steve