From: Andreas Mohr <andi@lisas.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition
Date: Mon, 6 Apr 2015 21:35:09 +0200 [thread overview]
Message-ID: <20150406193509.GA4476@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <1428311077-32198-1-git-send-email-kuleshovmail@gmail.com>
Hi,
> We no need to include <linux/compiler.h> to the arch/x86/boot/boot.h,
> because boot.h already includes "bitops.h" which already includes
> <linux/compiler.h>.
"Depends", I'd say (no pun, and intended :).
This currently implicitly working constellation
might break both for:
- boot.h no longer requiring bitops.h
- bitops.h no longer including linux/compiler.h
IMHO explicitly #include:ing parts
which certain code does actively depend on after all
is both a "code honesty"
and a documentation issue ("Hmm, which interfaces does this implementation
depend on? Ah, yeah...")
Food for thought,
Andreas Mohr
P.S.: thanks for your contribution!
--
GNU/Linux. It's not the software that's free, it's you.
next prev parent reply other threads:[~2015-04-06 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 9:04 Alexander Kuleshov
2015-04-06 19:35 ` Andreas Mohr [this message]
2015-04-07 7:32 ` Alexander Kuleshov
2015-04-07 8:35 ` Ingo Molnar
2015-04-07 8:56 ` Borislav Petkov
2015-04-07 9:17 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406193509.GA4476@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®