From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756059AbbDGOZn (ORCPT ); Tue, 7 Apr 2015 10:25:43 -0400 Received: from mail-db3on0114.outbound.protection.outlook.com ([157.55.234.114]:8160 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753713AbbDGOZl convert rfc822-to-8bit (ORCPT ); Tue, 7 Apr 2015 10:25:41 -0400 From: "Dhere, Chaitanya (C.)" To: "gregkh@linuxfoundation.org" , "navin.patidar@gmail.com" , "dan.carpenter@oracle.com" , "vthakkar1994@gmail.com" , "tapaswenipathak@gmail.com" , "abelmoyo.ab@gmail.com" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup Thread-Topic: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup Thread-Index: AQHQcT64o8J1yTDZZUyuKt5MvHCJXQ== Date: Tue, 7 Apr 2015 14:25:39 +0000 Message-ID: <20150407142449.GA3000@chaitanya-Ideapad-Z560> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [117.220.247.150] authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR06MB028; x-forefront-antispam-report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(92566002)(40100003)(2900100001)(122556002)(2501003)(50986999)(62966003)(86362001)(19580395003)(19580405001)(77156002)(33716001)(102836002)(2656002)(2860100001)(2201001)(66066001)(33656002)(46102003)(106116001)(87936001)(229853001)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:DB3PR06MB028;H:DB3PR06MB028.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:DB3PR06MB028;BCL:0;PCL:0;RULEID:;SRVR:DB3PR06MB028; x-forefront-prvs: 0539EEBD11 Content-Type: text/plain; charset="us-ascii" Content-ID: <392D43FA9206714FB260A200A37995B9@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2015 14:25:39.1307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR06MB028 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 86d955f..07ae6cf 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c @@ -5431,15 +5431,14 @@ u8 set_tx_beacon_cmd(struct adapter *padapter) goto exit; } - ptxBeacon_parm = kzalloc(sizeof(struct wlan_bssid_ex), GFP_KERNEL); + ptxBeacon_parm = kmemdup(&(pmlmeinfo->network), + sizeof(struct wlan_bssid_ex), GFP_KERNEL); if (ptxBeacon_parm == NULL) { kfree(ph2c); res = _FAIL; goto exit; } - memcpy(ptxBeacon_parm, &(pmlmeinfo->network), sizeof(struct wlan_bssid_ex)); - len_diff = update_hidden_ssid(ptxBeacon_parm->IEs+_BEACON_IE_OFFSET_, ptxBeacon_parm->IELength-_BEACON_IE_OFFSET_, pmlmeinfo->hidden_ssid_mode); -- 1.9.1