From: Borislav Petkov <bp@suse.de>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org, Suravee.Suthikulpanit@amd.com,
joro@8bytes.org
Subject: Re: [PATCH] x86, aperture: Check for GART before accessing GART registers
Date: Tue, 7 Apr 2015 16:57:38 +0200 [thread overview]
Message-ID: <20150407145737.GB3681@pd.tnic> (raw)
In-Reply-To: <5523EDC2.5080206@amd.com>
On Tue, Apr 07, 2015 at 09:46:26AM -0500, Aravind Gopalakrishnan wrote:
> Okay. I'll do that and correct the typos Ingo pointed out earlier and
> resend.
Btw, I think you should do the same in early_gart_iommu_check() too.
Doing the testing this way would mean that we first are testing for GART
hw presence and then do the rest of checks. If no GART hw, the rest of
the checks are meaningless.
Also, when testing do a "pci=noearly" boot which should make
!early_pci_allowed()
true and thus test that path too.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-04-07 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 14:32 Aravind Gopalakrishnan
2015-04-02 6:59 ` Borislav Petkov
2015-04-02 10:01 ` Ingo Molnar
2015-04-02 15:54 ` Aravind Gopalakrishnan
2015-04-02 16:06 ` Ingo Molnar
2015-04-02 16:23 ` Aravind Gopalakrishnan
2015-04-02 16:53 ` Borislav Petkov
2015-04-02 17:04 ` Aravind Gopalakrishnan
2015-04-02 17:17 ` Borislav Petkov
2015-04-02 18:19 ` Ingo Molnar
2015-04-06 23:10 ` Aravind Gopalakrishnan
2015-04-07 12:34 ` Borislav Petkov
2015-04-07 14:46 ` Aravind Gopalakrishnan
2015-04-07 14:57 ` Borislav Petkov [this message]
2015-04-07 20:34 ` Aravind Gopalakrishnan
2015-04-08 7:25 ` Borislav Petkov
2015-04-14 11:15 ` Jörg-Volker Peetz
2015-04-14 11:33 ` Borislav Petkov
2015-04-14 18:22 ` Jörg-Volker Peetz
2015-04-14 18:36 ` Borislav Petkov
2015-05-04 11:11 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407145737.GB3681@pd.tnic \
--to=bp@suse.de \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®