From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754747AbbDGPTU (ORCPT ); Tue, 7 Apr 2015 11:19:20 -0400 Received: from verein.lst.de ([213.95.11.211]:58843 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbbDGPTS (ORCPT ); Tue, 7 Apr 2015 11:19:18 -0400 Date: Tue, 7 Apr 2015 17:19:15 +0200 From: Christoph Hellwig To: Boaz Harrosh Cc: Christoph Hellwig , Dan Williams , linux-nvdimm , linux-fsdevel , "linux-kernel@vger.kernel.org" , X86 ML , Jens Axboe , Ingo Molnar Subject: Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload Message-ID: <20150407151915.GA18426@lst.de> References: <1427872339-6688-1-git-send-email-hch@lst.de> <551D60BE.1070101@plexistor.com> <551D6488.9090501@plexistor.com> <20150402164431.GB9774@lst.de> <5520F73E.3020602@plexistor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5520F73E.3020602@plexistor.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 05, 2015 at 11:50:06AM +0300, Boaz Harrosh wrote: > [ +0.000537] pmem: init 2 devices => 0 > > So I have all the information. And I know the driver was actually loaded > successfully on the expected two regions. The second number will always be 0, so no point in printing it. Also device can be hotplugged at runtime, e.g. your magic PCIe device, so iff you really want to print anything ->probe is the place for it. But I still don't think we need it, once booted you can trivially look up the information in sysfs.