From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402AbbDGP0X (ORCPT ); Tue, 7 Apr 2015 11:26:23 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42692 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbbDGP0V (ORCPT ); Tue, 7 Apr 2015 11:26:21 -0400 Date: Tue, 7 Apr 2015 17:26:10 +0200 From: Peter Zijlstra To: David Ahern Cc: acme@kernel.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH] perf tool: Fix type for references to data_head/tail Message-ID: <20150407152610.GP23123@twins.programming.kicks-ass.net> References: <1428420037-26599-1-git-send-email-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428420037-26599-1-git-send-email-dsahern@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 09:20:37AM -0600, David Ahern wrote: > data_head and data_tail are defined as __u64 in linux/perf_event.h, > but perf userspace uses int and unsigned int. Convert all references > to u64 for consistency. Ack on that. I suspect this is because >2G mmap()s are a tad silly, but yes its good to fix that.