From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbbDGSGe (ORCPT ); Tue, 7 Apr 2015 14:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbbDGSGb (ORCPT ); Tue, 7 Apr 2015 14:06:31 -0400 Date: Tue, 7 Apr 2015 20:06:23 +0200 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, namhyung@kernel.org Subject: Re: [PATCH 2/2] perf tools: Add options 'get', 'set' and 'unset' to 'perf-config'. Message-ID: <20150407180623.GB25980@krava.redhat.com> References: <1428169288-8482-1-git-send-email-treeze.taeung@gmail.com> <1428169288-8482-2-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428169288-8482-2-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 05, 2015 at 02:41:28AM +0900, Taeung Song wrote: > Add 'get' option that can show value of a specific config variable > and 'set' and 'unset' option that can create or replace a config variable. vould you please update the changelog with the new syntax examples? also Documentation/perf-config.txt wasn't updated anyway.. any chance we could use syntax here that would follow the sysctl style? sysctl [options] [variable[=value]] [...] sysctl -p [file or regexp] [...] # display current config perf config # display current config plus all keys with default values perf config -a # display key value: perf config report.queue # set key value: perf config report.queue=100M # remove key (not in sysctl) perf config -r report.queue jirka