From: Peter Zijlstra <peterz@infradead.org>
To: Luca Abeni <lucabe72@gmail.com>
Cc: henrik@austad.us, juri.lelli@gmail.com, raistlin@linux.it,
mingo@kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Luca Abeni <luca.abeni@unitn.it>
Subject: Re: [RFC 0/4] SCHED_DEADLINE documentation update
Date: Wed, 8 Apr 2015 16:44:21 +0200 [thread overview]
Message-ID: <20150408144421.GI5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1428494380-1917-1-git-send-email-luca.abeni@unitn.it>
On Wed, Apr 08, 2015 at 01:59:36PM +0200, Luca Abeni wrote:
> Hi all,
>
> here is the promised update for Documentation/scheduler/sched-deadline.txt.
> I send it as an RFC because of the following doubts:
> 1) I split the patches trying to isolate related changes. So,
> - the first patch fixes 2 typos that I noticed when updating the
> documentation
> - the second patch is based on Zhiqiang Zhang's patch and fixes some
> inconsistencies in the symbols used for period and execution times
> - the third patch adds a small discussion about admission tests for EDF on
> single processor systems
> - the fourth patch discusses the multi-processor case, adding some missing
> references
> I am not sure if this split is ok, or if I should do something different
> (should I put all of the changes in a single patch?)
This is indeed the preferred way.
> 2) The second patch is partly by me and partly by Zhiqiang Zhang. I do not
> know how to preserve Zhiqiang Zhang's authorship, so I added "Based on a
> patch by Zhiqiang Zhang" in the changelog. But I am not sure if this is
> the correct thing to do (maybe I should split this in 2 different patches?)
This is not uncommon practise and works for me.
> 3) I re-read the added text multiple times, and it looks ok to me... But I am
> not a native speaker, so it might contain English errors or sentences that
> are not clear enough
I send the one comment I had in reply to the relevant email.
Other than that it looked good to me so I've queued these patches.
Thanks!
next prev parent reply other threads:[~2015-04-08 14:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 11:59 Luca Abeni
2015-04-08 11:59 ` [RFC 1/4] Documentation/scheduler/sched-deadline.txt: fix typos Luca Abeni
2015-04-08 11:59 ` [RFC 2/4] Documentation/scheduler/sched-deadline.txt: use consistent namings Luca Abeni
2015-04-08 11:59 ` [RFC 3/4] Documentation/scheduler/sched-deadline.txt: Some notes on EDF schedulability Luca Abeni
2015-04-09 9:06 ` Henrik Austad
2015-04-09 9:34 ` Luca Abeni
2015-04-09 10:10 ` Henrik Austad
2015-04-09 10:35 ` Luca Abeni
2015-04-08 11:59 ` [RFC 4/4] Documentation/scheduler/sched-deadline.txt: add some references Luca Abeni
2015-04-08 14:43 ` Peter Zijlstra
2015-04-09 8:24 ` Juri Lelli
2015-04-09 9:13 ` Luca Abeni
2015-04-09 9:39 ` Henrik Austad
2015-04-09 9:44 ` Peter Zijlstra
2015-04-09 10:08 ` Luca Abeni
2015-04-09 10:11 ` Peter Zijlstra
2015-04-09 10:13 ` Henrik Austad
2015-04-09 11:55 ` Ingo Molnar
2015-04-09 10:05 ` Luca Abeni
2015-04-09 10:17 ` Henrik Austad
2015-04-08 14:44 ` Peter Zijlstra [this message]
2015-04-09 9:13 ` [RFC 0/4] SCHED_DEADLINE documentation update Luca Abeni
2015-04-09 9:17 ` Peter Zijlstra
2015-04-09 9:19 ` Luca Abeni
2015-04-09 9:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408144421.GI5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=henrik@austad.us \
--cc=juri.lelli@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=lucabe72@gmail.com \
--cc=mingo@kernel.org \
--cc=raistlin@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®