From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] lto: Add __noreorder and mark initcalls __noreorder
Date: Wed, 8 Apr 2015 15:31:12 -0700 [thread overview]
Message-ID: <20150408153112.bd375a883138f4c9fd319645@linux-foundation.org> (raw)
In-Reply-To: <1428499058-8322-1-git-send-email-andi@firstfloor.org>
On Wed, 8 Apr 2015 06:17:38 -0700 Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> gcc 5 has a new no_reorder attribute that prevents top level
> reordering only for that symbol.
I'm having trouble locating gcc documentation which explains all this
stuff.
> Kernels don't like any reordering of initcalls between files, as several
> initcalls depend on each other. LTO previously needed to use
> -fno-toplevel-reordering to prevent boot failures.
That's "-fno-toplevel-reorder", I believe?
> Add a __noreorder wrapper for the no_reorder attribute and use
> it for initcalls.
Head is spinning a bit. As this all appears to be shiny new
added-by-andi gcc functionality, it would be useful if we could have a
few more words describing what it's all about. Reordering of what with
respect to what and why and why is it bad. Why is gcc reordering
things anyway, and what's the downside of preventing this. Why is the
compiler reordering things rather than the linker. etc etc etc.
Please gently educate us ;)
next prev parent reply other threads:[~2015-04-08 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 13:17 Andi Kleen
2015-04-08 22:31 ` Andrew Morton [this message]
2015-04-08 23:50 ` Andi Kleen
2015-04-10 21:36 ` Andrew Morton
2015-04-10 23:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408153112.bd375a883138f4c9fd319645@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®