From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588AbbDHQnc (ORCPT ); Wed, 8 Apr 2015 12:43:32 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57083 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753844AbbDHQna (ORCPT ); Wed, 8 Apr 2015 12:43:30 -0400 Date: Wed, 8 Apr 2015 17:43:23 +0100 From: Mark Brown To: Laxman Dewangan Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20150408164323.GA6023@sirena.org.uk> References: <1428500227-3379-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GN2b77SjJylnpLHr" Content-Disposition: inline In-Reply-To: <1428500227-3379-1-git-send-email-ldewangan@nvidia.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: kconfig: make max8973 driver to depend on GPIOLIB X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GN2b77SjJylnpLHr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 08, 2015 at 07:07:07PM +0530, Laxman Dewangan wrote: > MAX8973 regulator driver uses the GPIO APIs for accessing the > control signal connected to its pin from host processor. >=20 > Make this driver depends on GPIOLIB. The GPIO usage in the driver appears to be optional, it handles the GPIO not being controllable. This suggests to me that the gpiolib dependency shouldn't be required and that it would be better to fix this by ensuring that all the gpiolib functions being used have appropriate stubs. Which ones are causing problems? --GN2b77SjJylnpLHr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJVqqAAoJECTWi3JdVIfQsWAH/29bxZfwZSVQR790Y9Z//xpR /QqLwZeAa/rZ88vwjLmz5zPhQqjJ+u0wBCF6htW9x32zohbvltEwQqGwtW4PI2By BFmnrfx50wVQ774SzIep1rkbfhkc7XzsmQ1PvNhIDMw5T+0dzjVjFFsYP04d1zGu 2KqDmhzPgudwJtjAR7Zop+qkLm9EXWn+pL1MJlXvBRF5sytm4idA6AiB2Gp6G6lQ X02wREF0rFs8EiiTjIuItPJN6u8tNXGnZ5eXsBLK+7PyWlKTfU+WS49B1FxB5H97 4UO2QYaJP14dUyJWM8vUc12qprzq+VyJnmGGV1Rh/zajwX08qr/U/Lz4pJXUXcM= =5ua1 -----END PGP SIGNATURE----- --GN2b77SjJylnpLHr--