From: Mark Brown <broonie@kernel.org>
To: Jonathan Richardson <jonathar@broadcom.com>
Cc: Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, Rafal Milecki <zajec5@gmail.com>
Subject: Re: [PATCH v2 5/5] spi: bcm-mspi: Add support to set serial baud clock rate
Date: Wed, 8 Apr 2015 20:53:33 +0100 [thread overview]
Message-ID: <20150408195333.GL6023@sirena.org.uk> (raw)
In-Reply-To: <1428516275-12819-6-git-send-email-jonathar@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Wed, Apr 08, 2015 at 11:04:35AM -0700, Jonathan Richardson wrote:
> + /*
> + * Enable clock if provided. The frequency can be changed by setting
> + * SPBR (serial clock baud rate) based on the desired 'clock-frequency'.
> + *
> + * Baud rate is calculated as: mspi_clk / (2 * SPBR) where SPBR is a
> + * value between 1-255. If not set then it is left at the h/w default.
> + */
> + data->clk = devm_clk_get(dev, "mspi_clk");
> + if (!IS_ERR(data->clk)) {
This is adding things to the DT binding, any new binding or binding
changes need to be documented. It should also be paying attention to
errors rather than silently ignoring them, at least -EPROBE_DEFER should
be handled properly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-04-08 19:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:04 [PATCH v2 0/5] Add MSPI support for Cygnus Jonathan Richardson
2015-04-08 18:04 ` [PATCH v2 1/5] ARM: dts: Add binding for Broadcom MSPI driver Jonathan Richardson
2015-04-08 18:04 ` [PATCH v2 2/5] spi: bcm53xx: Refactor driver to make nonspecific to 53xx SoCs Jonathan Richardson
2015-04-08 19:49 ` Mark Brown
2015-04-08 18:04 ` [PATCH v2 3/5] spi: bcm-mspi: Refactor to make driver " Jonathan Richardson
2015-04-08 18:04 ` [PATCH v2 4/5] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips Jonathan Richardson
2015-04-08 19:27 ` Jonas Gorski
2015-04-08 22:26 ` Jonathan Richardson
2015-04-08 20:03 ` Mark Brown
2015-04-09 22:26 ` Jonathan Richardson
2015-04-08 18:04 ` [PATCH v2 5/5] spi: bcm-mspi: Add support to set serial baud clock rate Jonathan Richardson
2015-04-08 19:32 ` Jonas Gorski
2015-04-08 19:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408195333.GL6023@sirena.org.uk \
--to=broonie@kernel.org \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome