From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] crypto: remove instance when test failed
Date: Thu, 9 Apr 2015 15:41:41 +0800 [thread overview]
Message-ID: <20150409074141.GA4394@gondor.apana.org.au> (raw)
In-Reply-To: <1461449.htSjBpksos@tachyon.chronox.de>
On Thu, Apr 09, 2015 at 09:36:03AM +0200, Stephan Mueller wrote:
>
> diff --git a/crypto/algapi.c b/crypto/algapi.c
> index f1d0307..cfca1de 100644
> --- a/crypto/algapi.c
> +++ b/crypto/algapi.c
> @@ -533,6 +533,13 @@ int crypto_register_instance(struct crypto_template *tmpl,
> if (IS_ERR(larval))
> goto unlock;
>
> + err = -EAGAIN;
> + if (unlikely(!crypto_mod_get(&inst->alg))) {
> + up_write(&crypto_alg_sem);
> + crypto_unregister_instance(inst);
> + goto err;
> + }
Just grab the reference count as soon as you enter the function
and then you can unconditionally drop the reference count at the
end. If you fail to grab it then just return an error and the
caller will free it for you.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-04-09 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 7:36 Stephan Mueller
2015-04-09 7:41 ` Herbert Xu [this message]
2015-04-09 9:22 ` Stephan Mueller
2015-04-09 9:40 ` Herbert Xu
2015-04-09 10:05 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409074141.GA4394@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®