From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817AbbDIPky (ORCPT ); Thu, 9 Apr 2015 11:40:54 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59319 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753567AbbDIPkw (ORCPT ); Thu, 9 Apr 2015 11:40:52 -0400 Date: Thu, 9 Apr 2015 16:40:45 +0100 From: Mark Brown To: Pelle Nilsson Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Message-ID: <20150409154045.GZ6023@sirena.org.uk> References: <1428591822-24279-1-git-send-email-per.nilsson@xelmo.com> <1428591822-24279-2-git-send-email-per.nilsson@xelmo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eSxef1sC1lPl9rZw" Content-Disposition: inline In-Reply-To: <1428591822-24279-2-git-send-email-per.nilsson@xelmo.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eSxef1sC1lPl9rZw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2015 at 05:03:42PM +0200, Pelle Nilsson wrote: > This callback is mandatory since txrx_bufs callback is defined. The lack of > it causes a kernel panic on first SPI transaction. Why is the callback mandatory if an empty implementation is OK? --eSxef1sC1lPl9rZw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJp18AAoJECTWi3JdVIfQltIH/2JCmNNJdBavugRiMUEJ7kFd N3oWJ+o3sPidEtVxUAdsIYzEayHTHSG84XfjM7CY7tfwJNxZktNPqeFaJSiQE3kn s1puZ2uF6ey8Tg+oYxtW6RWGXNgKmotqLk2o7f6MhrfnaQlnI2qiYfVB/pF57Lyt Ewf4cRjcYcWLgagFvyn+kee84b2kDigtKql7yyTwN9VQASjFQv72BWPqVGP7ms9Y BRrWo5JkhdUL8gegIEYGalgspIfXv08w0MVtpFEeEfD5KQjggPLYNQNV3+zV8R+F WqhqeaFvYusFwfYfpf8uzmvrDwAjeeBOV2a+ym15q3G07AK2B/kXRrTla1350/4= =8O43 -----END PGP SIGNATURE----- --eSxef1sC1lPl9rZw--