From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933111AbbDIQLL (ORCPT ); Thu, 9 Apr 2015 12:11:11 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59362 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932896AbbDIQLG (ORCPT ); Thu, 9 Apr 2015 12:11:06 -0400 Date: Thu, 9 Apr 2015 17:10:59 +0100 From: Mark Brown To: Pelle Nilsson Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Message-ID: <20150409161059.GA6023@sirena.org.uk> References: <1428591822-24279-1-git-send-email-per.nilsson@xelmo.com> <1428591822-24279-2-git-send-email-per.nilsson@xelmo.com> <20150409154045.GZ6023@sirena.org.uk> <55269FDC.8040306@xelmo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MDU+/juvgb4cyX6k" Content-Disposition: inline In-Reply-To: <55269FDC.8040306@xelmo.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MDU+/juvgb4cyX6k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2015 at 05:50:52PM +0200, Pelle Nilsson wrote: > On 2015-04-09 17:40, Mark Brown wrote: > > Why is the callback mandatory if an empty implementation is OK? > Ask the author of spi-bitbang. :-) What I'm trying to suggest is that you're perhaps fixing the wrong problem - make the callback optional if there's a good reason for it. Why is this patch the best fix? --MDU+/juvgb4cyX6k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJqSSAAoJECTWi3JdVIfQorAIAINBWRKEB/ixDnOrO2FyZbO/ GRSCnzgin9MxASSHvnGZL4/24nQUYZSRrFbIrXCGXeyzxg/MFcEtL2ogJBXfIDhS tvo7lRX2N0zmpp+OX80iceQ7TeL5OYkrcTLCp0YquN75XCmZHat9UaloA8lxGINR GKjAxgQn0OcFI3usILKvCqZ/2ufrb7abRc/AJR1SIn894j6I2KKiZxLX8f5jeyZw 97buap6uXOmVwzGyGRIuNsif+314bObWfnGdVs12vvY9gn6yK8wwCS6LwNsHI+ik GpUdTuncdRs4Dxp1sVTG0iWbCmZGKdywgnreOcjIxpWGtXQFXCVugGlrbyTASUE= =Cj4k -----END PGP SIGNATURE----- --MDU+/juvgb4cyX6k--