From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbbDJEUj (ORCPT ); Fri, 10 Apr 2015 00:20:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56345 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbDJEUg (ORCPT ); Fri, 10 Apr 2015 00:20:36 -0400 Date: Thu, 9 Apr 2015 21:24:41 -0700 From: Andrew Morton To: ZhangNeil Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] mm: show free pages per each migrate type Message-Id: <20150409212441.a64c3fe0.akpm@linux-foundation.org> In-Reply-To: References: <20150409134701.5903cb5217f5742bbacc73da@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Apr 2015 04:16:15 +0000 ZhangNeil wrote: > > I think we can eliminate nr_free[][]: > > what about make it as global__variable? That isn't as good - it permanently consumes memory and really requires new locking to protect the array from concurrent callers.