From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752551AbbDJFr4 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Apr 2015 01:47:56 -0400
Received: from mail-pd0-f170.google.com ([209.85.192.170]:36812 "EHLO
	mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752060AbbDJFrz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Apr 2015 01:47:55 -0400
Date: Fri, 10 Apr 2015 11:17:47 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Robin Karlsson <s.r.karlsson@gmail.com>
Cc: greg@kroah.com, teddy.wang@siliconmotion.com, sudip@vectorindia.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: sm750fb: fix brace coding style issues
Message-ID: <20150410054747.GB3561@sudip-PC>
References: <1428617536-9324-1-git-send-email-s.r.karlsson@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428617536-9324-1-git-send-email-s.r.karlsson@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 10, 2015 at 12:12:15AM +0200, Robin Karlsson wrote:
> This is a patch to sm750fb that fixes brace coding style errors and warnings found by checkpatch.pl
Try to limit this commit message to 72 char.

You should usually use scripts/get_maintainer.pl to see where to send
the mail.
> 
> Signed-off-by: Robin Karlsson <s.r.karlsson@gmail.com>
> ---
<snip>
> @@ -217,19 +214,17 @@ void hw_cursor_setData2(struct lynx_cursor * cursor,
>  		else
>  			opr = mask & color;
>  
> -		for(j=0;j<8;j++)
> -		{
> +		for(j=0;j<8;j++) {
>  
> -			if(opr & (0x80 >> j))
> -			{	//use fg color,id = 2
> +			if(opr & (0x80 >> j)) {	//use fg color,id = 2
this is introducing new checkpatch error.
Error: trailing statements should be on next line

regards
sudip
>  				data |= 2 << (j*2);