From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, namhyung@kernel.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.
Date: Fri, 10 Apr 2015 11:31:36 +0200 [thread overview]
Message-ID: <20150410093136.GB31326@krava.brq.redhat.com> (raw)
In-Reply-To: <1428589591-22838-2-git-send-email-treeze.taeung@gmail.com>
On Thu, Apr 09, 2015 at 11:26:31PM +0900, Taeung Song wrote:
> This patch consists of adding functions
> which get, set or remove a specific config variable.
> For the syntax examples,
>
> perf config [options] [section.subkey[=value]]
>
> display all perf config with default values
> # perf config
> or
> # perf config -a | --all
so this is ^^^ what the previous patch does right?
>
> display a specific key(section.subkey) and value
> # perf config report.queue
>
> set a specific key and value
> # perf config report.queue=100M
>
> remove a specific key
> # perf config -r | --remove report.queue
haven't checked the code but:
[jolsa@krava perf]$ ./perf config krava=true
The config variable does not contain a section: krava=true[jolsa@krava perf]$
missing '\n'
we can set anything now:
[jolsa@krava perf]$ ./perf config krava.krava=true
the restriction for only known keys would need similar stuff like
for the '-a' option I asked in the previous email right?
jirka
next prev parent reply other threads:[~2015-04-10 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 14:26 [PATCH 1/2] perf tools: Add 'perf-config' command Taeung Song
2015-04-09 14:26 ` [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable Taeung Song
2015-04-10 9:31 ` Jiri Olsa [this message]
2015-04-12 14:45 ` Taewoong Song
2015-04-09 15:57 ` [PATCH 1/2] perf tools: Add 'perf-config' command Arnaldo Carvalho de Melo
2015-04-10 8:53 ` Jiri Olsa
2015-04-12 14:44 Taeung Song
2015-04-12 14:44 ` [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable Taeung Song
2015-04-13 6:55 ` Namhyung Kim
[not found] ` <6F8981BC-A058-4D84-93FC-B7CB8ADDCC53@gmail.com>
2015-04-19 3:42 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410093136.GB31326@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®