From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754939AbbDJQ1M (ORCPT ); Fri, 10 Apr 2015 12:27:12 -0400 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:50458 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752285AbbDJQ1H (ORCPT ); Fri, 10 Apr 2015 12:27:07 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:3874:4250:5007:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12517:12519:12740:13069:13184:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: men08_20bfd2de6be40 X-Filterd-Recvd-Size: 1909 Date: Fri, 10 Apr 2015 12:27:03 -0400 From: Steven Rostedt To: Tom Zanussi Cc: pebolle@tiscali.nl, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tracing: Remove redundant module.h includes Message-ID: <20150410122703.52fcfe4c@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Apr 2015 11:05:02 -0500 Tom Zanussi wrote: > kallsyms.h now includes module.h, so remove module.h includes that > were apparently there only to satisfy kallsyms use of MODULE_NAME_LEN. Only remove it for those that need it for MODULE_NAME_LEN because it was used in KSYM_SYMBOL_LEN. But not the rest. Lots of these files use module code directly. Now you made it require kallsyms.h to get to that code. If for some reason we no longer need kallsyms.h, or that kallsyms.h no longer needs module.h, these files will not build. If code uses module code, it must include module.h. So NACK for this patch. To see what needs module.h, before reverting this patch, remove the module.h from kallsyms.h, and also remove the MODULE_NAME_LEN from it as well. Compile all the tracing code, and see what does not build. Those files will be the ones that you need to add back the module.h to. -- Steve