From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbbDJSyn (ORCPT ); Fri, 10 Apr 2015 14:54:43 -0400 Received: from smtprelay0039.hostedemail.com ([216.40.44.39]:43682 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751246AbbDJSyi (ORCPT ); Fri, 10 Apr 2015 14:54:38 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3872:3873:3874:4250:4321:5007:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12517:12519:12740:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: lift67_b40d3dd3780d X-Filterd-Recvd-Size: 3166 Date: Fri, 10 Apr 2015 14:54:36 -0400 From: Steven Rostedt To: Tom Zanussi Cc: pebolle@tiscali.nl, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tracing: Remove redundant module.h includes Message-ID: <20150410145436.6320a3a6@gandalf.local.home> In-Reply-To: <1428690304.19714.37.camel@picadillo> References: <20150410122703.52fcfe4c@gandalf.local.home> <1428690304.19714.37.camel@picadillo> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Apr 2015 13:25:04 -0500 Tom Zanussi wrote: > On Fri, 2015-04-10 at 12:27 -0400, Steven Rostedt wrote: > > On Fri, 10 Apr 2015 11:05:02 -0500 > > Tom Zanussi wrote: > > > > > kallsyms.h now includes module.h, so remove module.h includes that > > > were apparently there only to satisfy kallsyms use of MODULE_NAME_LEN. > > > > Only remove it for those that need it for MODULE_NAME_LEN because it > > was used in KSYM_SYMBOL_LEN. But not the rest. Lots of these files use > > module code directly. Now you made it require kallsyms.h to get to that > > code. If for some reason we no longer need kallsyms.h, or that > > kallsyms.h no longer needs module.h, these files will not build. > > > > If code uses module code, it must include module.h. > > > > I had grepped all those files for 'module' and didn't find anything > other than comments. The only files of those affected that use > KSYM_SYMBOL_LEN are trace_output and trace_syscalls, so I can respin the > patch including just those. > Hmm, I thought I did have some stuff in there for modules. Maybe not anymore. > But I don't see that any of the other files really use module code, and > looking at those again, none of them seem to need kallsyms either so > they could remove those includes as well... But I agree all that that > probably doesn't belong as part of this patchset. > > > So NACK for this patch. > > > > To see what needs module.h, before reverting this patch, remove the > > module.h from kallsyms.h, and also remove the MODULE_NAME_LEN from it as > > well. Compile all the tracing code, and see what does not build. Those > > files will be the ones that you need to add back the module.h to. > > > > Yeah, doing that I didn't see any build errors, but I'll stick with just > the explicit KSYM_SYMBOL_LEN-using files for this patchset to keep > things restricted to the specific case at hand. > Yeah, if they still compile without the module.h either in kallsyms, or explicitly being called, then it should be OK to remove them. And yes, in another patch. -- Steve