From: Peter Zijlstra <peterz@infradead.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: tj@kernel.org, svaidy@linux.vnet.ibm.com,
nacc@linux.vnet.ibm.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, lizefan@huawei.com,
anton@samba.org, bharata@linux.vnet.ibm.com,
cgroups@vger.kernel.org, paulmck@linux.vnet.ibm.com,
mingo@kernel.org, serge@hallyn.com
Subject: Re: [PATCH V2] cpuset: Add knob to make allowed masks hotplug invariant on legacy hierarchy
Date: Sat, 11 Apr 2015 10:35:37 +0200 [thread overview]
Message-ID: <20150411083537.GR27490@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20150410141118.11284.36206.stgit@preeti.in.ibm.com>
On Fri, Apr 10, 2015 at 07:41:52PM +0530, Preeti U Murthy wrote:
> The cpus_allowed and mems_allowed masks of a cpuset get overwritten
> after each hotplug operation on the legacy hierarchy of cgroups so as to
> remain in sync with the online mask. But there are use cases which
> expect user configured masks to remain unchanged.
>
> For instance, when hotplugged out CPUs are brought back online, they
> remain idle with none of the existing tasks allowed to run on them since
> the cpus_allowed mask was overwritten to not include them when they were
> offlined.
>
> We cannot change the legacy hierarchy design now to keep the allowed
> masks hotplug invariant since it is a user visible change. It was
> suggested instead to add a knob in the root cpuset directory which
> allows the user to specify if he wants the user configured masks to be
> hotplug invariant [1]. This knob will enforce the choice throughout the
> hierarchy. If the knob is set, the allowed maks will not be varied on
> hotplug. It is also to to be noted that this knob will appear in the
> root cgroup mounted on the legacy hierarchy alone since the default
> hierarchy does not overwrite the allowed masks anyway.
>
> Having said this, there are fair reasons to argue that the kernel is not
> responsible for taking care of user configurations in the face of
> hotplug. But one of the consequences of the current legacy hierarchy
> design, is that CPUs are left out from being used at all on online
> operations. The reason for this is not very obvious at first and several
> users have raised the issue as a bug. Hence the patch was strongly
> called for.
>
> Moreover the default hierarchy keeps the allowed masks hotplug invariant
> too. So the patch is not bringing about a fundamental change in the
> design of cgroups.
What you've not explained is why you can use this knob but not use the
other new mode?
next prev parent reply other threads:[~2015-04-11 8:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:11 Preeti U Murthy
2015-04-11 8:35 ` Peter Zijlstra [this message]
2015-04-11 11:21 ` Preeti U Murthy
2015-04-11 13:42 ` Peter Zijlstra
2015-04-13 7:01 ` Peter Zijlstra
2015-04-13 8:25 ` Preeti U Murthy
2015-04-13 12:16 ` Preeti U Murthy
2015-04-13 14:43 ` Peter Zijlstra
2015-04-15 11:40 ` Preeti U Murthy
2015-04-15 15:03 ` Serge E. Hallyn
2015-04-15 15:19 ` Peter Zijlstra
2015-04-15 15:30 ` Serge E. Hallyn
2015-04-15 15:48 ` Tejun Heo
2015-04-15 16:15 ` Serge E. Hallyn
2015-04-15 16:18 ` Tejun Heo
2015-04-15 16:36 ` Serge E. Hallyn
2015-04-16 11:57 ` Preeti U Murthy
2015-04-20 3:28 ` Zefan Li
2015-04-13 14:50 ` Tejun Heo
2015-04-13 15:05 ` Peter Zijlstra
2015-04-15 11:12 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150411083537.GR27490@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anton@samba.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=serge@hallyn.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome