From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbbDLTHE (ORCPT ); Sun, 12 Apr 2015 15:07:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:31795 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbbDLTHB (ORCPT ); Sun, 12 Apr 2015 15:07:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,566,1422950400"; d="scan'208";a="694179703" Date: Mon, 13 Apr 2015 03:06:26 +0800 From: kbuild test robot To: Jin Yao Cc: kbuild-all@01.org, Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Jie Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings Message-ID: <20150412190626.GA28170@athens.lkp.intel.com> References: <201504130318.BufQJB8v%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201504130318.BufQJB8v%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Jin Yao Signed-off-by: Fengguang Wu --- sst-ipc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/sound/soc/intel/common/sst-ipc.c +++ b/sound/soc/intel/common/sst-ipc.c @@ -283,8 +283,7 @@ void sst_ipc_fini(struct sst_generic_ipc if (ipc->tx_thread) kthread_stop(ipc->tx_thread); - if (ipc->msg) - kfree(ipc->msg); + kfree(ipc->msg); } EXPORT_SYMBOL_GPL(sst_ipc_fini);