mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.cz>
To: Minfei Huang <minfei.huang@hotmail.com>
Cc: jpoimboe@redhat.com, sjenning@redhat.com, jkosina@suse.cz,
	vojtech@suse.cz, live-patching@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] livepatch: Add a new function to verify the address and name match for extra module
Date: Mon, 13 Apr 2015 10:37:25 +0200	[thread overview]
Message-ID: <20150413083725.GA16088@pathway.suse.cz> (raw)
In-Reply-To: <BLU436-SMTP108A5A02BFF4DE5C8247F4194F80@phx.gbl>

On Sun 2015-04-12 21:15:53, Minfei Huang wrote:
> In order to restrict the patch, we can verify the provided function
> address and name match. Now we have can only verify the vmlinux function
> name and address.
> 
> Add a new function to verify extra module function name and address. The
> patch would not be patched, if the function name and address are not
> matched.

old_addr could be predefined only for vmlinux. It does not make sense
to define it for modules because they are loaded dynamically, each
time on a different addresses. It means that it does not make sense
to verify addresses from modules. They always need to be detected.

Best Regards,
Petr

  reply	other threads:[~2015-04-13  8:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1428844554-4015-1-git-send-email-minfei.huang@hotmail.com>
2015-04-12 13:15 ` Minfei Huang
2015-04-13  8:37   ` Petr Mladek [this message]
2015-04-13  9:11     ` Minfei Huang
2015-04-13  9:41       ` Petr Mladek
2015-04-13  9:50         ` Minfei Huang
2015-04-13 10:22           ` Petr Mladek
2015-04-13 10:37             ` Minfei Huang
2015-04-13 22:58               ` Josh Poimboeuf
2015-04-14  0:17                 ` Minfei Huang
2015-04-14  0:48                   ` Minfei Huang
2015-04-14  4:05                     ` Josh Poimboeuf
2015-04-14  4:56                       ` Minfei Huang
2015-04-12 13:15 ` [PATCH 2/2] livepatch: Fix the bug if the function name is larger than KSYM_NAME_LEN-1 Minfei Huang
2015-04-13  8:44   ` Petr Mladek
2015-04-13  9:16     ` Minfei Huang
2015-04-13 23:13   ` Josh Poimboeuf
2015-04-14  0:26     ` Minfei Huang
2015-04-14  4:57       ` Josh Poimboeuf
2015-04-14  5:03         ` Minfei Huang
2015-04-14  5:11           ` Josh Poimboeuf
2015-04-14  5:29             ` Minfei Huang
2015-04-14  5:32               ` Josh Poimboeuf
2015-04-14  5:45                 ` Minfei Huang
2015-04-14 15:11                   ` Josh Poimboeuf
2015-04-14 15:55                     ` Minfei Huang
2015-04-14 16:27                       ` Petr Mladek
2015-04-14 17:01                         ` Minfei Huang
2015-04-14 18:41                           ` Petr Mladek
2015-04-15  2:15                             ` Minfei Huang
2015-04-15  8:30                               ` Miroslav Benes
2015-04-15  8:49                                 ` Minfei Huang
2015-04-15 10:35                                 ` Minfei Huang
2015-04-15 11:58                                   ` Miroslav Benes
2015-04-15 16:24                                     ` Justin Keller
2015-04-16  2:10                                       ` Minfei Huang
2015-04-26 13:05                                     ` Minfei Huang
2015-04-27  8:41                                       ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413083725.GA16088@pathway.suse.cz \
    --to=pmladek@suse.cz \
    --cc=jkosina@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=minfei.huang@hotmail.com \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®