From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673AbbDMUXa (ORCPT ); Mon, 13 Apr 2015 16:23:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57900 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754572AbbDMUX1 (ORCPT ); Mon, 13 Apr 2015 16:23:27 -0400 Date: Mon, 13 Apr 2015 13:23:25 -0700 From: Andrew Morton To: Jarod Wilson Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, "Eric W. Biederman" , Al Viro , Miklos Szeredi , Zefan Li , Oleg Nesterov Subject: Re: [PATCH try #3] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline Message-Id: <20150413132325.7a3db5a8652f6c88f6d17973@linux-foundation.org> In-Reply-To: <20150413182848.GE36803@redhat.com> References: <1428638342-6782-1-git-send-email-jarod@redhat.com> <20150409211200.78b8631e.akpm@linux-foundation.org> <20150410121838.GA13391@redhat.com> <20150410141140.GA27200@p183.telecom.by> <20150410141329.GB27200@p183.telecom.by> <20150410180132.GB13391@redhat.com> <20150410220906.GA1991@p183.telecom.by> <20150413182848.GE36803@redhat.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Apr 2015 14:28:49 -0400 Jarod Wilson wrote: > > Well, it's 8 MB at least because of kmalloc and more when it starts > > to vmalloc, so either you increase but keep the limit, or allow > > to pin semi-arbitrary amount of kernel memory IF you want to stay > > with seqfile. My patch requires just 1 page plus whatever g_u_p > > requires. > > Okay, I've tested this out some. Its definitely more user-friendly than > having to require a boot param, and as a bonus, its even more > memory-efficient. Yes, its a bit fugly, but such is life sometimes... > > Though I do wonder if this should perhaps be a helper in mm/util.c like > get_cmdline, maybe replacing get_cmdline or adding an alternative that > gives you everything, rather than an arbitrarily limited length. I only > see one other place actually using get_cmdline so far. > > Tested-by: Jarod Wilson > Acked-by: Jarod Wilson Thanks, I'll take another look after the 4.0 merge flurry.