From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org,
richard@nod.at, fweisbec@gmail.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v9 3/4] cgroups: allow a cgroup subsystem to reject a fork
Date: Mon, 13 Apr 2015 10:24:39 -0400 [thread overview]
Message-ID: <20150413142439.GA2596@htj.duckdns.org> (raw)
In-Reply-To: <1428799917-15141-4-git-send-email-cyphar@cyphar.com>
On Sun, Apr 12, 2015 at 10:51:56AM +1000, Aleksa Sarai wrote:
> +/* list of all tags for subsystems */
> +enum cgroup_subsys_tag {
> +#define TAG_ID(_t) CGROUP_ ## _t
> +#define SUBSYS(_x) UNUSED_IDENT(_x),
> +#define TAG(_t) TAG_ID(_t), \
> + UNUSED_IDENT(_t) = TAG_ID(_t) - 2,
> +#define _COUNT(_t, _i) _i, \
> + CGROUP_ ## _t ## _COUNT = (TAG_ID(_t ## _END) - TAG_ID(_t ## _START)) + 1, \
> + UNUSED_IDENT(_t) = _i - 1,
> +#define COUNT(_t) _COUNT(_t, UNUSED_IDENT(_t))
> +#include <linux/cgroup_subsys.h>
> +#undef COUNT
> +#undef TAG
> +#undef SUBSYS
> +#undef TAG_ID
> +};
Ummm... is this really necessary? Can't we do something like the
following?
#define SUBSYS_TAG(tag) \
__##tag, \
tag = __##tag - 2,
--
tejun
next prev parent reply other threads:[~2015-04-13 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 0:51 [PATCH v9 0/4] cgroups: add pids subsystem Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 1/4] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 2/4] cgroups: replace explicit ss_mask checking with for_each_subsys_which Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 3/4] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-04-13 14:24 ` Tejun Heo [this message]
2015-04-14 0:33 ` Aleksa Sarai
2015-04-14 12:17 ` Tejun Heo
2015-04-16 13:57 ` Aleksa Sarai
2015-04-17 14:45 ` Tejun Heo
2015-04-17 20:35 ` Aleksa Sarai
2015-04-17 20:42 ` Tejun Heo
2015-04-17 20:48 ` Aleksa Sarai
2015-04-17 20:55 ` Tejun Heo
2015-04-17 21:06 ` Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 4/4] cgroups: implement the PIDs subsystem Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413142439.GA2596@htj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®