From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932633AbbDMTKa (ORCPT ); Mon, 13 Apr 2015 15:10:30 -0400 Received: from casper.infradead.org ([85.118.1.10]:52050 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932565AbbDMTK1 (ORCPT ); Mon, 13 Apr 2015 15:10:27 -0400 Date: Mon, 13 Apr 2015 21:10:11 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: rusty@rustcorp.com.au, mathieu.desnoyers@efficios.com, oleg@redhat.com, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org, tglx@linutronix.de, laijs@cn.fujitsu.com, linux@horizon.com, David Woodhouse , Rik van Riel , Andrea Arcangeli , Michel Lespinasse Subject: Re: [PATCH v5 04/10] rbtree: Make lockless searches non-fatal Message-ID: <20150413191011.GJ23123@twins.programming.kicks-ass.net> References: <20150413141126.756350256@infradead.org> <20150413141213.432590551@infradead.org> <20150413155008.GB6040@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150413155008.GB6040@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 05:50:08PM +0200, Ingo Molnar wrote: > > +static inline void rb_link_node_rcu(struct rb_node * node, struct rb_node * parent, > > + struct rb_node ** rb_link) > > Minor stylistic nit, the standard pattern I suspect has spaces fewer > by three: > > static inline void rb_link_node_rcu(struct rb_node *node, struct rb_node *parent, > struct rb_node **rb_link) OK, I'll also update the existing code in that file.