From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933101AbbDNRNu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Apr 2015 13:13:50 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:33525 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932975AbbDNRNm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Apr 2015 13:13:42 -0400
Date: Tue, 14 Apr 2015 19:13:24 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Suresh E. Warrier" <warrier@linux.vnet.ibm.com>
Cc: lklml <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] More precise timestamps for nested writes
Message-ID: <20150414171324.GE17717@twins.programming.kicks-ass.net>
References: <1428459449-10664-1-git-send-email-warrier@linux.vnet.ibm.com>
 <552C7B77.1000607@linux.vnet.ibm.com>
 <552C7C0D.1090201@linux.vnet.ibm.com>
 <552C7D89.2080802@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552C7D89.2080802@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 13, 2015 at 09:38:01PM -0500, Suresh E. Warrier wrote:
> +static u64 *get_write_timestamp(struct ring_buffer_per_cpu *cpu_buffer,
> +				unsigned long *flags)
> +{
> +	if (rb_precise_nested_write_ts()) {
> +		/*
> +		 * Ensure that we are not preempted until after we update
> +		 * the write timestamp.
> +		 */
> +		local_irq_save(*flags);
> +		return &cpu_buffer->last_stamp;

Yeah, ever hear about NMIs? This isn't going to work.

> +	} else {
> +		return &cpu_buffer->write_stamp;
> +	}
> +}