From: Eli Cohen <eli@dev.mellanox.co.il>
To: Honggang Li <honli@redhat.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures
Date: Tue, 14 Apr 2015 22:23:16 +0300 [thread overview]
Message-ID: <20150414192316.GB27750@mtldesk30> (raw)
In-Reply-To: <1428916918-24404-1-git-send-email-honli@redhat.com>
On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote:
> @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr)
> static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id)
> {
> struct page *page;
> - u64 addr;
> + u64 addr = 0;
> int err;
> int nid = dev_to_node(&dev->pdev->dev);
>
I really don't see any reason why you need to set addr to 0. Can you
please explain this?
Other than that the patch is ok.
next prev parent reply other threads:[~2015-04-14 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 9:21 Honggang Li
2015-04-14 18:05 ` David Miller
2015-04-14 19:23 ` Eli Cohen [this message]
2015-04-15 3:12 ` Honggang LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414192316.GB27750@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=honli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®