From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Xunlei Pang <xlpang@126.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
John Stultz <john.stultz@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Xunlei Pang <pang.xunlei@linaro.org>
Subject: Re: [PATCH 4/5] drivers/rtc/pl030: Replace deprecated rtc_tm_to_time() and rtc_time_to_tm()
Date: Wed, 15 Apr 2015 10:35:10 +0100 [thread overview]
Message-ID: <20150415093510.GW12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1429089611-29776-4-git-send-email-xlpang@126.com>
On Wed, Apr 15, 2015 at 05:20:10PM +0800, Xunlei Pang wrote:
> From: Xunlei Pang <pang.xunlei@linaro.org>
>
> The driver uses deprecated rtc_tm_to_time() and rtc_time_to_tm(),
> which will overflow in year 2106 on 32-bit machines.
>
> This patch solves this by:
> - Replacing rtc_tm_to_time() with rtc_tm_to_time64()
> - Replacing rtc_time_to_tm() with rtc_time64_to_tm()
>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
NAK.
How does this fix anything? The RTC contains 32-bit registers. Even
if you convert the struct tm to a 64-bit time, you can only write the
lowest 32-bits to the hardware. You can onyl read the lowest 32-bits
from the hardware too.
This patch solves /nothing/. In fact, it hides the fact that this RTC
is unable to represent dates after 2106.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-04-15 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 9:20 [PATCH 1/5] drivers/rtc/pcf8563: Replace deprecated rtc_time_to_tm() and rtc_tm_to_time() Xunlei Pang
2015-04-15 9:20 ` [PATCH 2/5] drivers/rtc/isl1208: Replace deprecated rtc_tm_to_time() Xunlei Pang
2015-04-15 9:20 ` [PATCH 3/5] drivers/rtc/sunxi: " Xunlei Pang
2015-04-15 9:20 ` [PATCH 4/5] drivers/rtc/pl030: Replace deprecated rtc_tm_to_time() and rtc_time_to_tm() Xunlei Pang
2015-04-15 9:35 ` Russell King - ARM Linux [this message]
2015-04-15 9:20 ` [PATCH 5/5] drivers/rtc/sa1100: " Xunlei Pang
2015-04-29 23:28 ` [5/5] " Alexandre Belloni
[not found] ` <OF1F6D43BC.C38481A0-ON48257E54.004FA90B-48257E54.004FD9D8@LocalDomain>
[not found] ` <OF8AF02B38.A9E97627-ON48257E55.00352B8F-48257E55.0037661B@zte.com.cn>
2015-06-01 19:43 ` Arnd Bergmann
2015-06-01 19:59 ` Alexandre Belloni
2015-06-03 14:17 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415093510.GW12732@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=rtc-linux@googlegroups.com \
--cc=xlpang@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®