From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018AbbDPQQD (ORCPT ); Thu, 16 Apr 2015 12:16:03 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33467 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794AbbDPQP5 (ORCPT ); Thu, 16 Apr 2015 12:15:57 -0400 Date: Thu, 16 Apr 2015 12:15:56 -0400 (EDT) Message-Id: <20150416.121556.187810209797975762.davem@davemloft.net> To: linux@roeck-us.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH] dsa: mv88e6xxx: Drop duplicate declaration of 'ret' variable From: David Miller In-Reply-To: <1429192190-31229-1-git-send-email-linux@roeck-us.net> References: <1429192190-31229-1-git-send-email-linux@roeck-us.net> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Apr 2015 09:15:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Thu, 16 Apr 2015 06:49:50 -0700 > A duplicate declaration of 'ret' can result in hiding an error code. > Drop it. > > Fixes: 17ee3e04ddbf ("net: dsa: Provide additional RMON statistics") > Signed-off-by: Guenter Roeck Applied, thank you.