From: David Miller <davem@davemloft.net>
To: linux@roeck-us.net
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH v2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max
Date: Fri, 17 Apr 2015 15:59:16 -0400 (EDT) [thread overview]
Message-ID: <20150417.155916.1229306319675431834.davem@davemloft.net> (raw)
In-Reply-To: <20150417194006.GA9538@roeck-us.net>
From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 17 Apr 2015 12:40:06 -0700
> On Fri, Apr 17, 2015 at 03:12:25PM -0400, Vivien Didelot wrote:
>> Since commit da4759c (sysfs: Use only return value from is_visible for
>> the file mode), it is possible to reduce the permissions of a file.
>>
>> So declare temp1_max with the DEVICE_ATTR_RW macro and remove the write
>> permission in dsa_hwmon_attrs_visible if set_temp_limit isn't provided.
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Looks good.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Applied, thanks everyone.
prev parent reply other threads:[~2015-04-17 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 19:12 Vivien Didelot
2015-04-17 19:40 ` Guenter Roeck
2015-04-17 19:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417.155916.1229306319675431834.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®