From: Steven Rostedt <rostedt@goodmis.org>
To: Milos Vyletel <milos@redhat.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org (open list:READ-COPY UPDATE...),
linux-doc@vger.kernel.org (open list:DOCUMENTATION),
jeff.haran@citrix.com
Subject: Re: [PATCH v2] rcu: small rcu_dereference doc update
Date: Fri, 17 Apr 2015 10:41:30 -0400 [thread overview]
Message-ID: <20150417104130.0f99fe4c@gandalf.local.home> (raw)
In-Reply-To: <1429281484-25345-1-git-send-email-milos@redhat.com>
On Fri, 17 Apr 2015 16:38:04 +0200
Milos Vyletel <milos@redhat.com> wrote:
> Make a note stating that repeated calls of rcu_dereference() may not
> return the same pointer if update happens while in critical section.
>
> Reported-by: Jeff Haran <jeff.haran@citrix.com>
> Signed-off-by: Milos Vyletel <milos@redhat.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
> Documentation/RCU/whatisRCU.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/RCU/whatisRCU.txt b/Documentation/RCU/whatisRCU.txt
> index 88dfce1..16622c9 100644
> --- a/Documentation/RCU/whatisRCU.txt
> +++ b/Documentation/RCU/whatisRCU.txt
> @@ -256,7 +256,9 @@ rcu_dereference()
> If you are going to be fetching multiple fields from the
> RCU-protected structure, using the local variable is of
> course preferred. Repeated rcu_dereference() calls look
> - ugly and incur unnecessary overhead on Alpha CPUs.
> + ugly, do not guarantee that the same pointer will be returned
> + if an update happened while in the critical section, and incur
> + unnecessary overhead on Alpha CPUs.
>
> Note that the value returned by rcu_dereference() is valid
> only within the enclosing RCU read-side critical section.
next prev parent reply other threads:[~2015-04-17 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 14:38 Milos Vyletel
2015-04-17 14:41 ` Steven Rostedt [this message]
2015-04-17 15:34 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417104130.0f99fe4c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=jeff.haran@citrix.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=milos@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®