From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbbDRLBH (ORCPT ); Sat, 18 Apr 2015 07:01:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50407 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbbDRLBE (ORCPT ); Sat, 18 Apr 2015 07:01:04 -0400 Date: Sat, 18 Apr 2015 12:00:55 +0100 From: Mark Brown To: Pelle Nilsson Cc: ezequiel@vanguardiasur.com.ar, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Message-ID: <20150418110055.GC26185@sirena.org.uk> References: <1428919685-14190-1-git-send-email-per.nilsson@xelmo.com> <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S1BNGpv0yoYahz37" Content-Disposition: inline In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --S1BNGpv0yoYahz37 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 14, 2015 at 03:40:17PM +0200, Pelle Nilsson wrote: > Some controller drivers have no need of this callback (spi-altera even > causes a NULL pointer dereference because it doesn't register the callback, > falsely assuming that it is already optional). I've applied this but really for something like this the commit message should be explaining *why* it's reasonable for the callback to be omitted. --S1BNGpv0yoYahz37 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVMjlmAAoJECTWi3JdVIfQ50IH/2MouOJWjYXgUv0V0IRIWeM9 I9CoE2XqrpCHIZItf5L22/aorm7y6pMPacixej7b9rl+ktsIJlSZTVUWQ2sMdzGN xdrf2lF84wHVuLtYUSVnkACEhpTmCIV7hLqDcK8i9FaIaE3kwguN2cbSLUVKPzXz MN9nJQ1ndduqMqR8B7ILniLwDVT420NYGbP73f0DgCQjn2qBBAkc/CBPuu+dKZLS rjNWlxGx8aU9tr62E69A/JXmL4Gw3jASAVcVXzHQEiyH7snL7C3iklBwGAgaO6Wz JXNlXABLBhk3CrTR0tRcbIiPCky8hLi7xk6etDXR4GX8dN2v6Ubt/7vy+nBLAuY= =21Ex -----END PGP SIGNATURE----- --S1BNGpv0yoYahz37--