mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf: Ensure symbols for plugins are exported
Date: Sat, 18 Apr 2015 17:46:18 +0200	[thread overview]
Message-ID: <20150418154618.GB15063@krava.brq.redhat.com> (raw)
In-Reply-To: <CA+rthh_dVt+Y=8__EozRfBSRCZ_rNk-gk5uuXDGu09U-WwTF3Q@mail.gmail.com>

On Fri, Apr 17, 2015 at 11:01:07PM +0200, Mathias Krause wrote:
> On 17 April 2015 at 17:34, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Sun, Apr 12, 2015 at 06:00:51PM +0200, Mathias Krause wrote:
> >> When building perf with perl or python support it implicitly gets linked
> >> with the -export-dynamic linker option through the additional linker
> >> flags, namely with -Wl,-E via perl or -Xlinker -export-dynamic via
> >> python. That flag is essential for the traceevent plugin support so we
> >> shouldn't rely on adding it implicitly.

I dont see the -E flag being added for perl on my setup,
but I guess that could be different on each distro

maybe we should look for proper fix and export only
needed symbols, anyway for this bugfix:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  reply	other threads:[~2015-04-18 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 16:00 Mathias Krause
2015-04-17 15:34 ` Jiri Olsa
2015-04-17 21:01   ` Mathias Krause
2015-04-18 15:46     ` Jiri Olsa [this message]
2015-04-22 20:12       ` Mathias Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150418154618.GB15063@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®