From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yorick Rommers <yorick-rommers@hotmail.com>
Cc: gregkh@linuxfoundation.org, alan@linux.intel.com,
helen.fornazier@gmail.com, iskaranth@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c
Date: Mon, 20 Apr 2015 11:02:09 +0300 [thread overview]
Message-ID: <20150420080209.GR10964@mwanda> (raw)
In-Reply-To: <BLU436-SMTP750BA893288782CD110EDE9EE20@phx.gbl>
On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote:
> From: Yorick <yorick-rommers@hotmail.com>
Don't include a From: unless you are sending a patch someone else wrote.
Otherwise we prefer to get it from your email From. Also you forgot
your last name.
> @@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
> * Don't stick a supertrak100 into cache aggressive modes
> */
>
> - osm_err("TID %03x error status: 0x%02x, detailed status: "
> - "0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> + osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n",
> + (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> status >> 24, status & 0xffff);
The new indenting is wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-20 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 20:12 Yorick Rommers
2015-04-20 8:02 ` Dan Carpenter [this message]
2015-04-20 9:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420080209.GR10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helen.fornazier@gmail.com \
--cc=iskaranth@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yorick-rommers@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome