From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Tejun Heo <tj@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Michal Nazarewicz" <mina86@mina86.com>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] __bitmap_parselist: fix bug in empty string handling
Date: Mon, 20 Apr 2015 13:17:25 -0700 [thread overview]
Message-ID: <20150420131725.3491233d901f1231af8fbc5d@linux-foundation.org> (raw)
In-Reply-To: <1429293604-5210-1-git-send-email-cmetcalf@ezchip.com>
On Fri, 17 Apr 2015 14:00:04 -0400 Chris Metcalf <cmetcalf@ezchip.com> wrote:
> bitmap_parselist("", &mask, nmaskbits) will erroneously set bit
> zero in the mask. The same bug is visible in cpumask_parselist()
> since it is layered on top of the bitmask code, e.g. if you boot with
> "isolcpus=", you will actually end up with cpu zero isolated.
>
> The bug was introduced in commit 4b060420a596 ("bitmap, irq: add
> smp_affinity_list interface to /proc/irq") when bitmap_parselist()
> was generalized to support userspace as well as kernelspace.
>
> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
> Cc: stable@vger.kernel.org
I don't think we need to backport a fix for a 4 year old bug which has
very minor consequences. Am I wrong?
next prev parent reply other threads:[~2015-04-20 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 18:00 Chris Metcalf
2015-04-20 20:17 ` Andrew Morton [this message]
2015-04-20 23:50 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420131725.3491233d901f1231af8fbc5d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cmetcalf@ezchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mina86@mina86.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®