From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbbDTW2r (ORCPT ); Mon, 20 Apr 2015 18:28:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44154 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbbDTW2q (ORCPT ); Mon, 20 Apr 2015 18:28:46 -0400 Date: Mon, 20 Apr 2015 15:28:45 -0700 From: Andrew Morton To: Geert Uytterhoeven Cc: Andy Shevchenko , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] hexdump: Make test data really const Message-Id: <20150420152845.e10be7a50a5da922510e97e4@linux-foundation.org> In-Reply-To: <1429212729-4059-1-git-send-email-geert@linux-m68k.org> References: <1429212729-4059-1-git-send-email-geert@linux-m68k.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Apr 2015 21:32:09 +0200 Geert Uytterhoeven wrote: > lib/test-hexdump.c: In function ___test_hexdump___: > lib/test-hexdump.c:74: warning: assignment discards qualifiers from pointer target type > > Make all test data "const char * const" and "__initconst", and the > "result" variable "const char * const" to fix this. Linus has already fixed the warning with 17974c054db303. I think what remains of your patch makes sense, but we don't actually have a changelog which explains why we're doing it. Please cook up a fresh patch when convenient?