From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753824AbbDTR4d (ORCPT ); Mon, 20 Apr 2015 13:56:33 -0400 Received: from mail-qk0-f180.google.com ([209.85.220.180]:32910 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753373AbbDTR4b (ORCPT ); Mon, 20 Apr 2015 13:56:31 -0400 Date: Mon, 20 Apr 2015 13:56:26 -0400 From: Tejun Heo To: Jan Kara Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, Miklos Szeredi , Trond Myklebust Subject: Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into bdi_writeback Message-ID: <20150420175626.GB4206@htj.duckdns.org> References: <1428350318-8215-1-git-send-email-tj@kernel.org> <1428350318-8215-13-git-send-email-tj@kernel.org> <20150420150231.GA17020@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420150231.GA17020@quack.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 05:02:31PM +0200, Jan Kara wrote: > Maybe bdi_wb_destroy() would be somewhat more descriptive than > bdi_wb_exit()? Otherwise the patch looks good to me. You can add: > Reviewed-by: Jan Kara Hmmm... maybe, I don't know. I feel weird matching up destroy with init instead of create. Why is exit weird? Thanks. -- tejun