From: Mark Brown <broonie@kernel.org>
To: Bert Vermeulen <bert@biot.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: rb4xx: Fix set_cs logic.
Date: Mon, 20 Apr 2015 21:37:03 +0100 [thread overview]
Message-ID: <20150420203703.GG14892@sirena.org.uk> (raw)
In-Reply-To: <1429538005-1985-1-git-send-email-bert@biot.com>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote:
> As it turns out, the set_cs() enable parameter refers to the logic level
> on the CS pin, not the state of chip selection.
> This broke functionality of the LEDs behind the CPLD, or at least delayed
> the commands until another one came in to toggle CS.
No, the enable parameter *should* refer to chip select assertion (see
how we handle GPIO chip selects). However it's possible that this
device has an inverted chip select and should be registered with the
SPI_CS_HIGH flag?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-20 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 13:53 Bert Vermeulen
2015-04-20 20:37 ` Mark Brown [this message]
2015-04-21 9:46 ` Geert Uytterhoeven
2015-04-21 11:01 ` Bert Vermeulen
2015-04-21 11:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420203703.GG14892@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®