From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbbDUIvc (ORCPT ); Tue, 21 Apr 2015 04:51:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52626 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbbDUIv3 (ORCPT ); Tue, 21 Apr 2015 04:51:29 -0400 Date: Tue, 21 Apr 2015 10:51:19 +0200 From: Jan Kara To: Tejun Heo Cc: Jan Kara , axboe@kernel.dk, linux-kernel@vger.kernel.org, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, Miklos Szeredi , Trond Myklebust Subject: Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into bdi_writeback Message-ID: <20150421085119.GA24278@quack.suse.cz> References: <1428350318-8215-1-git-send-email-tj@kernel.org> <1428350318-8215-13-git-send-email-tj@kernel.org> <20150420150231.GA17020@quack.suse.cz> <20150420175626.GB4206@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420175626.GB4206@htj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 20-04-15 13:56:26, Tejun Heo wrote: > On Mon, Apr 20, 2015 at 05:02:31PM +0200, Jan Kara wrote: > > Maybe bdi_wb_destroy() would be somewhat more descriptive than > > bdi_wb_exit()? Otherwise the patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > Hmmm... maybe, I don't know. I feel weird matching up destroy with > init instead of create. Why is exit weird? I can easily understand what "initializing writeback structure" means but "exiting writeback structure" doesn't really make sense to me. OTOH "destroying writeback structure" does make sense to me. That's the only reason. Honza -- Jan Kara SUSE Labs, CR