From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755408AbbDUPMY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Apr 2015 11:12:24 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:48182 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755329AbbDUPMW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Apr 2015 11:12:22 -0400
Date: Tue, 21 Apr 2015 17:12:16 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf/x86/intel: Add cpu_(prepare|starting|dying) for
 core_pmu
Message-ID: <20150421151216.GD3182@worktop.meeting.verilan.com>
References: <1429606465-10271-1-git-send-email-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429606465-10271-1-git-send-email-jolsa@kernel.org>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 21, 2015 at 10:54:25AM +0200, Jiri Olsa wrote:
> @@ -2559,6 +2563,9 @@ static __initconst const struct x86_pmu core_pmu = {
>  	.guest_get_msrs		= core_guest_get_msrs,
>  	.format_attrs		= intel_arch_formats_attr,
>  	.events_sysfs_show	= intel_event_sysfs_show,

Could you also insert a little comment here how these methods are for
'funny' 'hardware' ?

> +	.cpu_prepare		= intel_pmu_cpu_prepare,
> +	.cpu_starting		= intel_pmu_cpu_starting,
> +	.cpu_dying		= intel_pmu_cpu_dying,
>  };
>  
>  struct intel_shared_regs *allocate_shared_regs(int cpu)
> -- 
> 1.9.3
>