From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755319AbbDUPT3 (ORCPT ); Tue, 21 Apr 2015 11:19:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087AbbDUPTZ (ORCPT ); Tue, 21 Apr 2015 11:19:25 -0400 Date: Tue, 21 Apr 2015 17:18:27 +0200 From: Jiri Olsa To: Peter Zijlstra Cc: Jiri Olsa , lkml , Andi Kleen , Arnaldo Carvalho de Melo , Ingo Molnar , Paul Mackerras , Stephane Eranian Subject: Re: [PATCH] perf/x86/intel: Add cpu_(prepare|starting|dying) for core_pmu Message-ID: <20150421151827.GB13169@krava.redhat.com> References: <1429606465-10271-1-git-send-email-jolsa@kernel.org> <20150421151216.GD3182@worktop.meeting.verilan.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150421151216.GD3182@worktop.meeting.verilan.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2015 at 05:12:16PM +0200, Peter Zijlstra wrote: > On Tue, Apr 21, 2015 at 10:54:25AM +0200, Jiri Olsa wrote: > > @@ -2559,6 +2563,9 @@ static __initconst const struct x86_pmu core_pmu = { > > .guest_get_msrs = core_guest_get_msrs, > > .format_attrs = intel_arch_formats_attr, > > .events_sysfs_show = intel_event_sysfs_show, > > Could you also insert a little comment here how these methods are for > 'funny' 'hardware' ? ook, will do v3 jirka > > > + .cpu_prepare = intel_pmu_cpu_prepare, > > + .cpu_starting = intel_pmu_cpu_starting, > > + .cpu_dying = intel_pmu_cpu_dying, > > }; > > > > struct intel_shared_regs *allocate_shared_regs(int cpu) > > -- > > 1.9.3 > >