From: Tejun Heo <tj@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, keescook@chromium.org,
casey@schaufler-ca.com, cocci@systeme.lip6.fr,
Jani Nikula <jani.nikula@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Hannes Reinecke <hare@suse.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers
Date: Tue, 21 Apr 2015 16:58:57 -0400 [thread overview]
Message-ID: <20150421205857.GG9455@htj.duckdns.org> (raw)
In-Reply-To: <20150421165516.GL5622@wotan.suse.de>
Hello, Luis.
On Tue, Apr 21, 2015 at 06:55:16PM +0200, Luis R. Rodriguez wrote:
> A use then would be for instance:
>
> module_param_config_on_off(power_efficient, wq_power_efficient, 0444,
> IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT));
>
> this as an alternative would enable use of other static / global variables but
> I'm not sure if these are good use cases to promote, given that all this is to
> help with initial set up, so I believe the restrictions are for the better.
I was thinking more of cases where CONFIG should be inverted or
and/or'd. In general I don't think we conventionally embed
IS_ENABLED() in this sort of macros. It just jumps at me as a weird
restriction. What do others think?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-21 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 23:30 [PATCH v1 0/6] module params: few simplifications Luis R. Rodriguez
2015-04-20 23:30 ` Luis R. Rodriguez
2015-04-21 10:20 ` Arend van Spriel
2015-04-20 23:30 ` [PATCH v1 2/6] kernel/module.c: use generic module param operaters for sig_enforce Luis R. Rodriguez
2015-04-20 23:30 ` [PATCH v1 3/6] kernel/params.c: generalize bool_enable_only Luis R. Rodriguez
2015-04-20 23:30 ` [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers Luis R. Rodriguez
2015-04-20 23:42 ` Julian Calaby
2015-04-21 16:41 ` Luis R. Rodriguez
2015-04-21 15:21 ` Tejun Heo
2015-04-21 16:55 ` Luis R. Rodriguez
2015-04-21 20:58 ` Tejun Heo [this message]
2015-04-22 7:15 ` Rusty Russell
2015-04-22 15:42 ` Luis R. Rodriguez
2015-04-20 23:30 ` [PATCH v1 5/6] kernel/workqueue.c: use module_param_config_on_off() for power_efficient Luis R. Rodriguez
2015-04-20 23:30 ` [PATCH v1 6/6] kernel/module.c: use module_param_config_on() for sig_enforce Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421205857.GG9455@htj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=cocci@systeme.lip6.fr \
--cc=geert@linux-m68k.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jani.nikula@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®