From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933205AbbDVCin (ORCPT ); Tue, 21 Apr 2015 22:38:43 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:36214 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392AbbDVCik (ORCPT ); Tue, 21 Apr 2015 22:38:40 -0400 Date: Wed, 22 Apr 2015 10:38:44 +0800 From: Boqun Feng To: Jan Kara Cc: Boqun Feng , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Is it OK to export symbols 'getname' and 'putname'? Message-ID: <20150422023844.GA32658@fixme-laptop.cn.ibm.com> References: <1427309152-25129-1-git-send-email-boqun.feng@gmail.com> <20150329042744.GA1477@fixme-laptop> <20150407083826.GA1048@fixme-laptop.cn.ibm.com> <20150411235655.GK889@ZenIV.linux.org.uk> <20150412011318.GL889@ZenIV.linux.org.uk> <20150417123530.GA4249@fixme-laptop.cn.ibm.com> <20150420155507.GK17020@quack.suse.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <20150420155507.GK17020@quack.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042202-0013-0000-0000-000004C94C73 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote: > On Fri 17-04-15 20:35:30, Boqun Feng wrote: > > Hi Al, > >=20 > >=20 > > I'm trying to clean that part of code you mentioned, and I found I have > > to export the symbols 'getname' and 'putname' as follow to replace that > > __getname() caller: > >=20 > > diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/stagin= g/lustre/lustre/llite/dir.c > > index a182019..014f51a 100644 > > --- a/drivers/staging/lustre/lustre/llite/dir.c > > +++ b/drivers/staging/lustre/lustre/llite/dir.c > ... > > +#define ll_getname(filename) getname(filename) > > +#define ll_putname(name) putname(name) > Bonus points for getting rid of these useless defines. Yeah, make sense. Thank you for your comments, Regards, Boqun >=20 > > diff --git a/fs/namei.c b/fs/namei.c > > index ffab2e0..7a0948c 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -205,6 +205,7 @@ getname(const char __user * filename) > > { > > return getname_flags(filename, 0, NULL); > > } > > +EXPORT_SYMBOL(getname); > > =20 > > struct filename * > > getname_kernel(const char * filename) > > @@ -254,6 +255,7 @@ void putname(struct filename *name) > > } else > > __putname(name); > > } > > +EXPORT_SYMBOL(putname); > > =20 > > static int check_acl(struct inode *inode, int mask) > > { > >=20 > >=20 > >=20 > > Is that a good idea to export these symbols, given that lustre may be > > the only user?=20 > Yes, it is a good idea. >=20 > Honza > --=20 > Jan Kara > SUSE Labs, CR --azLHFNyN32YCQGCU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVNwmsAAoJEEl56MO1B/q4GG4H/0Ap8EuOOeTw2JeLLAwySg21 SZnSg+0ExOcvV+VIE83zyW8hvAlLXDlzCnvveinsdEhLCnlhL+hP9MD9iEC6RYt5 Gxcb2PFm9bcHmC7J5Mp6jy1vTtp9JhM/349TzfP+urmlDHuJavqXZ5wghJl9+rYg Gcwnvq3bK8D7pLiSY5PJtmoSvE5bar/jN4B2AxijAUXmzn3DBtGdHhucgpXFksRh ZM+WN4MplciILhB0+b8gy5iwX5/VbNHlOHHXlRX+MGNTfz0De2XCxnkUdr7VfsFI MLK9iMtoH4o4DqTEq2DugWZmHDcX4kZtbvmVYqRwcJ+6MHplZMbaYLwzt2boSr4= =GldC -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--