From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: peterhuewe@gmx.de, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Jianyu Zhan <nasa4836@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrzej Hajda <a.hajda@samsung.com>, NeilBrown <neilb@suse.de>,
Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH v2] tpm: enable PPI for TPM 2.0
Date: Wed, 22 Apr 2015 08:44:22 +0300 [thread overview]
Message-ID: <20150422054422.GB6764@intel.com> (raw)
In-Reply-To: <20150421185825.GA8366@roeck-us.net>
On Tue, Apr 21, 2015 at 11:58:33AM -0700, Guenter Roeck wrote:
> On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
> > Enabled PPI interface to the character device sysfs directory accessible
> > both for 1.x and 2.0 devices.
> >
> > The ppi group is moved from the platform device directory to the
> > character device directory. In order to retain backwards compatibility
> > with the 1.x devices, a symlink is created to the platform device
> > directory.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Reviewed-by: Jason Gunthorpe <jason.gunthorpe@obsidianresearch.com>
> > ---
> > drivers/char/tpm/tpm-chip.c | 21 +++++++++++++--------
> > drivers/char/tpm/tpm.h | 17 ++++++-----------
> > drivers/char/tpm/tpm_ppi.c | 34 +++++++++++-----------------------
> > fs/kernfs/dir.c | 1 +
> > fs/sysfs/group.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> > include/linux/sysfs.h | 8 ++++++++
>
> Shouldn't the sysfs changes be a separate patch ?
Yes, I think it would make sense. I'll refine this as a patch set.
Thanks.
> Guenter
/Jarkko
next prev parent reply other threads:[~2015-04-22 5:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 18:30 Jarkko Sakkinen
2015-04-21 18:58 ` Guenter Roeck
2015-04-22 5:44 ` Jarkko Sakkinen [this message]
2015-04-21 19:33 ` Jason Gunthorpe
2015-04-22 5:57 ` Jarkko Sakkinen
2015-04-22 16:38 ` [tpmdd-devel] " Jarkko Sakkinen
2015-04-22 17:22 ` Jason Gunthorpe
2015-04-22 18:10 ` Greg Kroah-Hartman
2015-04-23 4:55 ` Jarkko Sakkinen
2015-04-21 19:52 ` Greg Kroah-Hartman
2015-04-22 5:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422054422.GB6764@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=a.hajda@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=nasa4836@gmail.com \
--cc=neilb@suse.de \
--cc=peterhuewe@gmx.de \
--cc=sw@simonwunderlich.de \
--cc=tj@kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome