From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757452AbbDVFuV (ORCPT ); Wed, 22 Apr 2015 01:50:21 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57419 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755821AbbDVFuT (ORCPT ); Wed, 22 Apr 2015 01:50:19 -0400 Date: Tue, 21 Apr 2015 22:50:15 -0700 From: Christoph Hellwig To: Jan Kara Cc: Boqun Feng , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Is it OK to export symbols 'getname' and 'putname'? Message-ID: <20150422055015.GA3731@infradead.org> References: <1427309152-25129-1-git-send-email-boqun.feng@gmail.com> <20150329042744.GA1477@fixme-laptop> <20150407083826.GA1048@fixme-laptop.cn.ibm.com> <20150411235655.GK889@ZenIV.linux.org.uk> <20150412011318.GL889@ZenIV.linux.org.uk> <20150417123530.GA4249@fixme-laptop.cn.ibm.com> <20150420155507.GK17020@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420155507.GK17020@quack.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote: > > Is that a good idea to export these symbols, given that lustre may be > > the only user? > Yes, it is a good idea. It was if lustre was in core code and these idiotic ioctls were something we had to live with. But lustre is in staging code, and we shouldn't export symbols just for shitty staging code. Intead lustre should clean up their mess and get rid of these ioctls that do path name lookups.