From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>, Petr Slansky <slansky@usa.net>,
Adam C Powell IV <hazelsct@mit.edu>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pl2303, visor: Match I330 phone more precisely
Date: Wed, 22 Apr 2015 14:38:00 +0200 [thread overview]
Message-ID: <20150422123800.GA27882@kroah.com> (raw)
In-Reply-To: <20150422112038.GA16828@localhost>
On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote:
> On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote:
> > Samsung has just released a portable USB3 SSD, coming in a very small
> > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
> > already used by the pl2303 USB serial driver and the Palm Visor driver
> > for the Samsung I330 phone cradle. Having pl2303 or visor pick up this
> > device ID results in conflicts with the usb-storage driver, which
> > handles the newly released portable USB3 SSD.
>
> First of all, the device should not be claimed by both pl2303 and visor.
> This predates the git, but it looks like the device id should simply be
> removed from pl2303. Care to do that as a preparatory patch?
It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky
asked me to add it, and sent a patch as he had the device.
But before that, back in 2003 Adam emailed saying that the visor driver
worked with the device, and sent me a patch for it. I didn't notice the
duplicate ids for well over a decade now :(
I'd bet this is really a pl2303 device, given that the visor driver was
just a "dumb" pipe to the device and the pilot sync tools never cared
about baud rates and the like, so odds are the visor entry should be
removed.
Petr, do you still have this device? Is it still really a pl2303
device?
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-22 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 15:07 [PATCH] pl2303: Remove antiquated support for I330 phone Jason A. Donenfeld
2015-04-21 17:03 ` Greg Kroah-Hartman
2015-04-22 10:14 ` [PATCH] pl2303, visor: Match I330 phone more precisely Jason A. Donenfeld
2015-04-22 10:28 ` Sergei Shtylyov
2015-04-22 11:20 ` Johan Hovold
2015-04-22 12:35 ` [PATCH 1/2] pl2303: Remove support for Samsung I330 Jason A. Donenfeld
2015-04-22 12:35 ` [PATCH 2/2] visor: Match I330 phone more precisely Jason A. Donenfeld
2015-04-22 14:30 ` Johan Hovold
2015-04-29 10:43 ` Johan Hovold
2015-04-22 12:38 ` Greg Kroah-Hartman [this message]
2015-04-22 12:42 ` [PATCH] pl2303, " Jason A. Donenfeld
2015-04-22 13:33 ` Greg Kroah-Hartman
2015-04-22 12:48 ` [PATCH 1/2] visor: Remove support for Samsung I330 Jason A. Donenfeld
2015-04-22 12:48 ` [PATCH 2/2] pl2303: Match I330 phone more precisely Jason A. Donenfeld
2015-04-22 14:20 ` [PATCH] pl2303, visor: " Johan Hovold
2015-04-22 14:58 ` Greg Kroah-Hartman
2015-04-22 15:02 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422123800.GA27882@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=hazelsct@mit.edu \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=slansky@usa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®