From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754003AbbDVUMF (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 16:12:05 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:49630 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751429AbbDVUMD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 16:12:03 -0400
Date: Wed, 22 Apr 2015 13:12:01 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Don Zickus <dzickus@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: [PATCH] watchdog: Fix watchdog_nmi_enable_all()
Message-Id: <20150422131201.c989c12c4ab97bec57e5c7fd@linux-foundation.org>
In-Reply-To: <1429714069-176478-1-git-send-email-dzickus@redhat.com>
References: <1429714069-176478-1-git-send-email-dzickus@redhat.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 22 Apr 2015 10:47:49 -0400 Don Zickus <dzickus@redhat.com> wrote:

> From: Ulrich Obergfell <uobergfe@redhat.com>
> 
> The 'watchdog_user_enabled' variable is only used as an 'interface'
> to the /proc/sys/kernel/watchdog parameter. The actual state of the
> watchdog is tracked by bits in the 'watchdog_enabled' variable. So,
> watchdog_nmi_enable_all() should check the NMI_WATCHDOG_ENABLED bit
> in 'watchdog_enabled'.

What are the user-visible effects of the patch?  Please always include
this information when fixing a bug.