From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030567AbbDWS1L (ORCPT ); Thu, 23 Apr 2015 14:27:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34066 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966432AbbDWS1J (ORCPT ); Thu, 23 Apr 2015 14:27:09 -0400 Date: Thu, 23 Apr 2015 20:27:05 +0200 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Thomas Petazzoni , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: Disable DMA support if DMA is not available Message-ID: <20150423182705.GB12779@kroah.com> References: <1429812412-9551-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429812412-9551-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 23, 2015 at 08:06:52PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `fbtft_framebuffer_alloc': > (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' > > As DMA support is already optional, make it depend on HAS_DMA. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/staging/fbtft/fbtft-core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index 53b748be27124793..88bf4705ebadc590 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -47,9 +47,13 @@ static unsigned long debug; > module_param(debug, ulong, 0); > MODULE_PARM_DESC(debug, "override device debug level"); > > +#ifdef CONFIG_HAS_DMA > static bool dma = true; > module_param(dma, bool, 0); > MODULE_PARM_DESC(dma, "Use DMA buffer"); > +#else > +static const bool dma; > +#endif > I don't see how this change can fix the build error you show above. What am I missing? thanks, greg k-h